Skip to content

Several fixes. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 18, 2025
Merged

Several fixes. #111

merged 27 commits into from
Aug 18, 2025

Conversation

JaBistDuNarrisch
Copy link

@JaBistDuNarrisch JaBistDuNarrisch commented Aug 18, 2025 •
edited
Loading

Fixes #115
Fixes #114
Fixes #113
Fixes #112
Fixes #110
Fixes #109
Fixes #108
Fixes #107
Fixes #106
Fixes #105
Fixes #104
Fixes #103

JaBistDuNarrisch added 21 commits August 13, 2025 08:38
Refactoring test class structure part I
dccadb3
Added SQLite begin transaction in base test class
bac2e3f
Oracle, SQL Server, SQLite and Postgre SQL Begin Transaction moved to…
c3d24ad 
… base class
GetColumns tests
69afb8c
Renamings
2df78f4
Minor changes
ce77eae
Read data type in GetColumns in SQL Server
a584a2c
Extended parser for SQL Server default values. Test is now green for …
f676552 
…SQL Server
Added changes to GetColumns in Oracle.
7048961
Added changes to GetColumns in Oracle.
2e92291
Oracle test GetColumns_DefaultValues_Succeeds is green
d7ac6ec
SQLite does not support default BLOB values => throw
b693821
PostgreSQL GetColumns with default columns are green
af56450
Added RemoveConstraint
e0f686c
Escape Oracle strings
17b4e54
Create new database for Postgre
93d2986
Refactoring test
722e1f8
Added GetCheckConstraints, RemoveForeignKey and much more...
5c95ede
Added Contains compatible with old .NET version
03febdd
Added checkConstraint test
3f61417
Added check for CheckConstraints in AddTable in TransformationProvider
ddf5015
@JaBistDuNarrisch JaBistDuNarrisch self-assigned this Aug 18, 2025
JaBistDuNarrisch added 2 commits August 18, 2025 10:15
@JaBistDuNarrisch JaBistDuNarrisch merged commit f227757 into master Aug 18, 2025
1 check passed
@JaBistDuNarrisch JaBistDuNarrisch deleted the sql-server-default-values branch August 18, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jogibear9988 jogibear9988 jogibear9988 approved these changes

Assignees

@JaBistDuNarrisch JaBistDuNarrisch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Server parser of default values does not work correctly and implements only a few data types. Should be fixed and extended. SQL Server type detection should be completely overhauled - does not work correctly Oracle: Only bool, Guid and DateTime are implemented in Default in OracleDialect SQL Server: Default value of type DateTime/DateTime2 is not parsed SQL Server: GetColumns parses datetime as DbType.Date instead of DbType.DateTime/DateTime2 - Major bug
Oracle: Dialect for byte array byte[] fails => OracleException (0x80004005): ORA-03062: Ein Komma oder eine rechte Klammer fehlen SQLite: RemoveForeignKey does nothing - silently! It is overridden but just returns - nothing else. Implement GetCheckConstraints() - at least for generic tests No feedback if table or constraint does not exist in RemoveConstraint in TransformationProvider PrimaryKeyExists should be overridden and should throw in SQLite since it does not support named primary keys.
2 participants
@JaBistDuNarrisch @jogibear9988